Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the *BSD family #12

Merged
merged 2 commits into from
Mar 31, 2019
Merged

Add support for the *BSD family #12

merged 2 commits into from
Mar 31, 2019

Conversation

hrkfdn
Copy link
Contributor

@hrkfdn hrkfdn commented Mar 30, 2019

They're not very different on the userland side we act in, so just adding them to the list of supported OS' should work.

Tested on OpenBSD.

amodm
amodm reviewed Mar 31, 2019
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
@amodm
Copy link
Owner

amodm commented Mar 31, 2019

Thx for adding BSD to the list, @hrkfdn. Two changes requested:

  1. Modify the README.md to include BSD
  2. Modify the fn name open_on_linux_using_browser_env to open_on_unix_using_browser_env

@hrkfdn
Copy link
Contributor Author

hrkfdn commented Mar 31, 2019

Okay, changed as requested.

@amodm amodm merged commit 28ed7b9 into amodm:master Mar 31, 2019
@amodm
Copy link
Owner

amodm commented Mar 31, 2019

Released as 0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amodm amodm amodm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hrkfdn @amodm